Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIO-8874: fixed conditional value field for time component #5764

Merged
merged 1 commit into from
Aug 24, 2024

Conversation

TanyaGashtold
Copy link
Contributor

@TanyaGashtold TanyaGashtold commented Aug 22, 2024

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-8874

Description

What changed?

Before time field was used a value field for time component in the simple conditional UI. But time field has required input mask and does not allow to enter partial time value. I have changed it so that textfield is used as a value field in condition with time.

Dependencies

https://github.com/formio/premium/pull/323
formio/formio#1788

How has this PR been tested?

Manually

Checklist:

  • I have completed the above PR template
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants